Posted: Sun Jan 29, 2012 10:42 pm Post subject: patch to handle uppercase .MOV files
'MOV' videos were passing the tivo_compatible_container check when inFile contains an uppercase extension and passed to TiVo as is. This should have been flagged as not compatible and remuxed. Was causing failed video transfers. This one caused me a bit of confusion for awhile.
Affects wmcbrine fork as well.
Easy fix but wasn't sure if it was the best way to handle it.
From 7b34460ad27a8f23e58408fed6612018e47813de Mon Sep 17 00:00:00 2001
From: Taylor Spencer <email@example.com>
Date: Sun, 29 Jan 2012 17:31:49 -0500
Subject: [PATCH] =?UTF-8?q?Fix=20bug=20when=20checking=20for=20.mov=20extens?=
Content-Type: text/plain; charset=UTF-8
This was causing the tivo_compatible_container check to return True erroneously which caused transfer errors.
plugins/video/transcode.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/plugins/video/transcode.py b/plugins/video/transcode.py
index ac5e31e..4c45410 100644
@@ -703,7 +703,7 @@ def tivo_compatible_container(vInfo, inFile, mime=''):
message = (True, '')
container = vInfo['container']
if ((mime == 'video/mp4' and
- (container != 'mov' or inFile.endswith('.mov'))) or
+ (container != 'mov' or inFile.lower().endswith('.mov'))) or
(mime == 'video/bif' and container != 'asf') or
(mime == 'video/x-tivo-mpeg-ts' and container != 'mpegts') or
(mime in ['video/x-tivo-mpeg', 'video/mpeg', ''] and
You cannot post new topics in this forum You cannot reply to topics in this forum You cannot edit your posts in this forum You cannot delete your posts in this forum You cannot vote in polls in this forum You cannot attach files in this forum You can download files in this forum